Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cst/cache: ubsan fix, fix highly unlikely full cache trim if free disk info is delayed, more tests #24631

Merged
merged 3 commits into from
Dec 23, 2024
Merged

cst/cache: ubsan fix, fix highly unlikely full cache trim if free disk info is delayed, more tests #24631

merged 3 commits into from
Dec 23, 2024

Conversation

nvartolomei
Copy link
Contributor

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

WillemKauf
WillemKauf previously approved these changes Dec 20, 2024
View reviewed changes
src/v/redpanda/admin/server.cc Show resolved Hide resolved
tests/rptest/tests/cloud_storage_cache_test.py Outdated Show resolved Hide resolved
@vbotbuildovich
Copy link
Collaborator

Retry command for Build#60013

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/e2e_shadow_indexing_test.py::ShadowIndexingWhileBusyTest.test_create_or_delete_topics_while_busy@{"cloud_storage_type":2,"short_retention":true}

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Dec 20, 2024 •
edited
Loading

CI test results

test results on build#60013
test_id test_kind job_url test_status passed
partition_balancer_simulator_test_rpunit.partition_balancer_simulator_test_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60013#0193e520-62bd-465d-bb9d-741888f6daa7 FLAKY 1/2
rptest.tests.datalake.partition_movement_test.PartitionMovementTest.test_cross_core_movements.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/60013#0193e562-b23c-4dd3-935a-4de6f2d319b9 FLAKY 1/6
rptest.tests.e2e_shadow_indexing_test.ShadowIndexingWhileBusyTest.test_create_or_delete_topics_while_busy.short_retention=True.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/60013#0193e57d-dc41-447c-89fe-41df078793d5 FAIL 0/6
test results on build#60073
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60073#0193f400-5453-4726-aa44-59bee8775d15 FLAKY 1/2

@nvartolomei
cst/cache: allow admin api trim only if cache is initialized
30a15ed 
Fixes UBSAN assertion caused by invoking a function call on
uninitialized cache object.

include/c++/v1/vector:1394:10: runtime error: reference binding to null pointer of type 'seastar::sharded<cloud_storage::cache>::entry'
@nvartolomei
cst/cache: skip trim if free disk info is not available
cecaf85 
Otherwise it ends up removing everything from the cache when disk info is not yet available.
@nvartolomei
rptest: test cloud storage cache manual trim behavior
84312e5
@nvartolomei nvartolomei merged commit 06ae9f3 into redpanda-data:dev Dec 23, 2024
18 checks passed
dotnwat
dotnwat reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. seastar invoke_on will throw if the local service hasn't been created, but that happens in sharded::start where the underlying vector is built. seems like they should also do that simple check of the vector being large enough too to catch thsi UB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat left review comments

@WillemKauf WillemKauf WillemKauf approved these changes

@Lazin Lazin Awaiting requested review from Lazin

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvartolomei @vbotbuildovich @dotnwat @WillemKauf